Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix investor transaction amount calculations #60

Closed
wants to merge 12 commits into from

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Sep 29, 2023

When querying investorTransactions all of the transactions that were considered tokenTypes were returning numbers far too small to be realistic (usually zero). By moving all to the currencyTypes the amounts were calculated properly again. Seems to me that the events actually always return the tokenAmount and therefore it must always be converted into the currencyAmount

TODO:

  • fix tests

@hieronx
Copy link
Contributor

hieronx commented Oct 2, 2023

Closing in favour of #61

@hieronx hieronx closed this Oct 2, 2023
@hieronx hieronx deleted the fix-investor-tx-amounts branch October 2, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants