Reports #20
Draft
Reports #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onnovisser
reviewed
Nov 21, 2024
src/Reports/index.ts
Outdated
| } | ||
|
|
||
| generateReport(type: ReportProcessorType, filter?: ReportFilter) { | ||
| _generateReport(type: 'balanceSheet' | 'cashflow', filter?: ReportFilter) { | ||
| return this._root._query( |
There was a problem hiding this comment.
Suggested change
| return this._root._query( | |
| return this._query( |
So it also takes the pool id into account when caching the observable
onnovisser
reviewed
Nov 21, 2024
src/Reports/index.ts
Outdated
| } | ||
| [type, filter?.from, filter?.to, filter?.groupBy], | ||
| () => | ||
| defer(() => { |
There was a problem hiding this comment.
doesn't need the defer here. The callback being called won't immediately fire off requests.
There was a problem hiding this comment.
hinted at by the fact that the callback inside defer isn't an async function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request...
#