Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note on root logger level #872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snobu
Copy link

@snobu snobu commented Mar 21, 2020

#871 for context.

@snobu snobu requested a review from lzchen as a code owner March 21, 2020 18:56
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@snobu
Copy link
Author

snobu commented Mar 21, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@@ -37,6 +37,19 @@ This example shows how to send a warning level log to Azure Monitor.
logger.addHandler(AzureLogHandler(connection_string='InstrumentationKey=<your-instrumentation_key-here>'))
logger.warning('Hello, World!')

**IMPORTANT NOTE:**
The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_.
The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_ by default. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_.

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You can pull the latest master to rebase and I'll get this merged.

@snobu snobu requested review from aabmass, hectorhdzg, songy23 and a team as code owners May 13, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants