remove redundant steps

censeo-io · Feb 19, 2024 · 4038e53 · 4038e53
1 parent 81293c1
commit 4038e53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml
@@ -11,7 +11,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - run: cd hosting && npm ci && node_modules/.bin/nx build
+      # `nx test` and `nx build` are ran via Firebase, as a pre-deploy step
+      - run: cd hosting && npm ci
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:
           repoToken: "${{ secrets.GITHUB_TOKEN }}"

diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -13,7 +13,8 @@ jobs:
       pull-requests: write
     steps:
       - uses: actions/checkout@v4
-      - run: cd hosting && npm ci && node_modules/.bin/nx lint && node_modules/.bin/nx test && node_modules/.bin/nx build
+      # `nx test` and `nx build` are ran via Firebase, as a pre-deploy step
+      - run: cd hosting && npm ci && node_modules/.bin/nx lint
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:
           repoToken: "${{ secrets.GITHUB_TOKEN }}"