Friend list service rework + Online working in MH3U #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked the interface used to communicate with
/dev/fpd(IOSU friend list service daemon) with the goal of the protocol being binary compatible with the one on the actual console. This means that the officialnn_fp.rplfriend service driver can now be used in place of our HLE implementation (via cafeLibs directory).From a regular users perspective there should be no difference between running our HLE driver or the Nintendo one. Most of the benefits are "under the hood", e.g. making it easier to cross-compare behavior and check for errors in our implementation.
While working on this PR I also found a couple of bugs in the friend code. As a result of fixing those Monster Hunter 3 Ultimate now has functioning online!