Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor localization adjustments #984

Merged
merged 5 commits into from
Sep 30, 2023
Merged

Minor localization adjustments #984

merged 5 commits into from
Sep 30, 2023

Conversation

Fs00
Copy link
Contributor

@Fs00 Fs00 commented Sep 30, 2023

This PR fixes some more untranslated UI strings I've stumbled upon.
While I was at it, I took the opportunity to make some minor improvements to the GUI code:

  • removed all usages of the wxT macro, which is useless since wxWidgets 3.0
  • addressed a small issue in commit f6c3c96, which mistakenly added two translatable strings containing nothing or just newlines

One last thing: I added the wxString::FromUTF8 to the wxString <-> std::string conversions mentioned in the code style guidelines.
I think that it should be the preferred way to convert a std::string into a wxString. Also, wxWidgets 3.3 will add a FromUTF8 overload that takes a std::string_view, so we'll be able to use that one in place of our custom helper.

@Exzap Exzap merged commit 5b27d32 into cemu-project:main Sep 30, 2023
5 checks passed
@Fs00 Fs00 deleted the strings-adjustments branch September 30, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants