Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some more untranslated UI strings I've stumbled upon.
While I was at it, I took the opportunity to make some minor improvements to the GUI code:
One last thing: I added the
wxString::FromUTF8
to thewxString <-> std::string
conversions mentioned in the code style guidelines.I think that it should be the preferred way to convert a
std::string
into awxString
. Also, wxWidgets 3.3 will add a FromUTF8 overload that takes a std::string_view, so we'll be able to use that one in place of our custom helper.