Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception in Nsyshid on Windows and log it in logDebug #977

Conversation

Squall-Leonhart
Copy link
Contributor

@Squall-Leonhart Squall-Leonhart commented Sep 25, 2023

This keeps Cemu from crashing when nsyshid's logging encounters an error on Windows and prints the type of exception encountered to the log.

Currently a bad descriptor error is occurring on some toypad accesses, I have not addressed this (Don't know how), but this makes cemu no longer crash when they happen.

This keeps Cemu from crashing when nsyshid's logging encounters an error on Windows and prints the type of exception encountered to the log.
@ssievert42
Copy link
Contributor

Hey, it looks like I managed to forget that call to fmt::print in there when hacking on nsyshid.
Since that call shouldn't be there in the first place, does removing it fix the crash as well?

@Squall-Leonhart
Copy link
Contributor Author

Superseded by #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants