debugger: add logging breakpoint and misc fixes #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces logging breakpoints, something which might be helpful if you want to analyze more complex interactions in the code. You can set these by right-clicking empty space in the breakpoint window. Some noteworthy features: - If you give the comment a name in the breakpoint window it'll also log it so that you can more easily identify multiple logging breakpoints. - If you enable advanced PPC debugging in the Debug->Logging menu you can also have it generate stack traces for each hit, which allows you to more easily see how the code ultimately ends up executing your code. Do note that the stack trace feature works best when Cemu is set to use interpreter mode. Minor features/fixes include things like: - You can now also delete breakpoints by right-clicking them in the breakpoint window. - The GoTo window now prefers hex addresses, which allows you to enter non "0x" prefixed hex addresses more easily, which is especially useful for the breakpoint and memory dump windows. - You can now also create execution breakpoints with a manually inputted address in the breakpoint window, alongside the new logging breakpoints. - And some other minor fixes.
I don't know how this ended up getting broken, but it should now make for a nicer experience that'll remember any debugger comments and breakpoints you make across sessions and game launches.
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces logging breakpoints, something which might be helpful if you want to analyze more complex interactions in the code. You can set these by right-clicking empty space in the breakpoint window. Some noteworthy features:
Another "addition" is that the debugger will now store any breakpoints and comments across sessions. I'm not sure how it got broken, but at least now it doesn't lose all the comments and breakpoints you make after you restart Cemu.
Minor features/fixes include things like: