Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: exclude fmt10 #921

Merged
merged 1 commit into from
Jul 30, 2023
Merged

cmake: exclude fmt10 #921

merged 1 commit into from
Jul 30, 2023

Conversation

abouvier
Copy link
Contributor

Related to #919 and #920.

@Exzap Exzap merged commit 34ff9da into cemu-project:main Jul 30, 2023
5 checks passed
@Exzap
Copy link
Member

Exzap commented Jul 30, 2023

Interesting that this works. Thanks for the contribution!

@Exzap
Copy link
Member

Exzap commented Jul 30, 2023

Does this actually fix the issue on arch? I was under the impression that only fmt 10 is available now

@abouvier
Copy link
Contributor Author

abouvier commented Jul 31, 2023

No, but I created a fmt9 package on the AUR in the meantime. But if you have both fmt and fmt9 installed, CMake will pick the fmt10 version without this fix because fmt actually accept anything.

@abouvier abouvier deleted the patch-1 branch July 31, 2023 03:59
@alba4k
Copy link

alba4k commented Jul 31, 2023

This is still a workaround however, as forcing an old library version is not a solution (in the long term)

But yea having an outdated dependency is with no doubt better than refusing to compile ahah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants