CI: Add macOS build #273
Closed
CI: Add macOS build #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-add Windows and Ubuntu builds (removed for testing), add artifact uploads, remove git and make from `brew install`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in 254
Based on build instructions found here
I assume this may need to wait to be merged until a few of the macOS fixes (139?) are merged, but this might serve as a draft until then. In addition, since I haven't found a commit that completely compiles on macOS yet, I do not know what the macOS binary name is, so if it's different from that of Linux, this PR will require some changes.
Edit:
This was supposed to be a draft, but I misclicked.