Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle button to VPAD show screen input #1383

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

goeiecool9999
Copy link
Collaborator

@goeiecool9999 goeiecool9999 commented Oct 17, 2024

In addition to adding a checkbox this also alters the behaviour of pressing the "show screen" button. Currently if you enable the "Launch with gamepad view" option in the game profile, pressing the button does nothing. I've changed it so it acts like the TAB key and shows the TV screen.
image
image

I'm not happy with the alignment of the volume slider and the checkbox. That's the main reason why this is marked as draft. I think it needs to look a little more polished.
EDIT: I've added a windows screenshot since writing this and I think it doesn't look as bad on windows.
Closes: #1373
Closes: #916

@goeiecool9999
Copy link
Collaborator Author

I figured out how to align the text so the PR is ready now.
image

@goeiecool9999 goeiecool9999 marked this pull request as ready for review October 17, 2024 18:39
@Exzap
Copy link
Member

Exzap commented Oct 17, 2024

I don't think it's clear to the user what toggle screen actually means in this context and that it relates to the show screen button. You should at the very least add a tooltip that explains what it does, but maybe you can think of a better solution that is more intuitive. I was never super happy with show screen either, but there is not enough space for show GamePad screen.

Also, put the label on the left and then have the text-less checkbox on the right of it. That way it will visually line up with the above options. I think that makes more sense than having it line up with the volume slider

@goeiecool9999
Copy link
Collaborator Author

but maybe you can think of a better solution that is more intuitive.

I tried making a box around it with wxStaticBox but I couldn't figure out how to make it look good 🤷
This is what it looks like now:
image

@Exzap Exzap merged commit f9a4b2d into cemu-project:main Oct 18, 2024
5 checks passed
@goeiecool9999 goeiecool9999 deleted the controllertoggledrc branch October 24, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants