Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial NTAG and NFC implementation #1193

Merged
merged 8 commits into from
May 22, 2024

Conversation

GaryOderNichts
Copy link
Contributor

@GaryOderNichts GaryOderNichts commented May 4, 2024

This PR adds support for NTAG which is used by Pokemon Rumble U to read and write tags.
NTAG is built on top of NFC, which this PR also adds basic support for.

Checklist:

  • Properly implement states and callbacks to allow playing Rumble U (fixes Pokemon Rumble U Black Screen #686)
  • Fully support reading from tags
  • Support writing to tags (needs testing)
  • Support for formatting tags (When does Rumble U use NTAGFormat?)
  • Properly integrate nn_nfp with NTAG and NFC

@GaryOderNichts GaryOderNichts force-pushed the ntag_nfc/initial_support branch 4 times, most recently from 954b5e0 to 47df187 Compare May 9, 2024 22:59
@GaryOderNichts GaryOderNichts marked this pull request as ready for review May 18, 2024 15:28
@Exzap
Copy link
Member

Exzap commented May 22, 2024

I see this also implements the /dev/ccr_nfc IOSU interface and driver, very nice work 👍
There is some redundancy between the added Stream helper and src/util/helpers/Serializer.h and Deserializer.h but it's not a big deal and everything else looks good to me so lets merge this now. Thanks!

@Exzap Exzap merged commit a059338 into cemu-project:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants