Depend on crypto-password, and add support for PBKDF2 #137

zonotope · 2015-03-10T02:15:10Z

Fixes #110

from bcrypt-credential-fn.

This reverts commit 8b531cc.

This reverts commit 9881fb2.

cemerick · 2015-03-13T09:58:12Z

This looks really great on a quick skim. Could you do a couple things before I really dig in and then merge this though?

Please squash your commits down to a really small number (probably one?)
There are some areas that pop on the diff only because of formatting changes. Could you revert those lines? I don't care that much about formatting, I just want blame to be as useful as possible.

Thanks so much for working on this. Looking forward to merging! :-D

zonotope · 2015-03-13T22:22:37Z

@cemerick it was easier just to do it all in a different branch. #139 is the new pr.

zonotope added 23 commits March 8, 2015 23:05

add crypto-password dep, and remove jbcrypt.

d9cd5a3

formatting.

9881fb2

use crypto.password.bcrypt functions.

20edd3d

hof to return a credential function when given a verifier. refactored

4a5119f

from bcrypt-credential-fn.

add pbkdf2

870be7f

formatting

8b531cc

add bcrypt suffixes to tests.

e1184bd

test pbkdf2 credential fn.

3b83a6b

Revert "formatting"

96412b0

This reverts commit 8b531cc.

Revert "formatting."

73169d7

This reverts commit 9881fb2.

add docstring to build-credential-fn

fd45f45

more precise.

00c52f0

throw in scrypt

665f8e8

even more clarity.

f4a415c

this should be hidden.

eb6fa82

simple scrypt test.

833940e

comment hash-pbkdf2

2f601b8

comment pbkdf2-verify, and clarify comment for bcrypt-verify

cb08e3e

fix typo.

941a560

docstring for pbkdf2-credential-fn

5a57918

docstring for hash-scrypt

0b26114

docstring for scrypt-verify.

7b1d64a

docstring for scrypt-credential-fn.

0a3641b

zonotope closed this Mar 13, 2015

Provide feedback