Set VPN notification persistent #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IronVeil <[email protected]>
Signed-off-by: IronVeil <[email protected]>
|
This should only be an option, I am happy with the fact is not persistent, other VPN have persistent ones and is annoying |
|
Added basic option in 54374a2. Might need a better icon, and could make it disabled if there is no notification permission,. |
|
Here is a requested screenshot of the settings menu, I think the icon may need changing but other than that, it looks like this.
|
|
Thanks for the PR. @hussainmohd-a to review. |
hussainmohd-a
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1136 , the notification for the active VPN is dismisable. Therefore, it is easy to swipe it away and kill the app. This one-line change makes the notification "ongoing".