Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition ODIS to cloud function Gen 2 #22

Merged
merged 113 commits into from
Oct 13, 2023

Conversation

aaronmgdr
Copy link
Member

Description

Updated to use firebase cloud function gen2

Added a LRU Cache to the combiner to keep a cache of the issuers DEK used to authenticate. This avoids a mandatory call to fullnode to get the DEK.

Related issues

Fixes celo-org/celo-monorepo#10498
Fixes celo-org/celo-monorepo#10499
Fixes #45

alecps and others added 30 commits August 2, 2023 16:52
* update packages

* change format to number
Refactors Signer to be more performant
….0.0

# Conflicts:
#	packages/phone-number-privacy/combiner/package.json
#	packages/phone-number-privacy/combiner/src/index.ts
#	packages/phone-number-privacy/common/README.md
#	packages/phone-number-privacy/common/src/utils/authentication.ts
#	packages/phone-number-privacy/monitor/src/query.ts
#	packages/phone-number-privacy/monitor/src/scripts/run-load-test.ts
#	packages/phone-number-privacy/monitor/src/test.ts
#	packages/phone-number-privacy/signer/src/common/controller.ts
#	packages/phone-number-privacy/signer/src/common/io.ts
#	packages/phone-number-privacy/signer/src/pnp/endpoints/quota/io.ts
#	packages/phone-number-privacy/signer/src/pnp/endpoints/sign/action.ts
#	packages/phone-number-privacy/signer/src/pnp/endpoints/sign/io.ts
#	packages/phone-number-privacy/signer/src/server.ts
#	yarn.lock
Adds tracing to the combiner
add mock signer interfaces
* first pass into transforming into handlers

* Extract methods out of IO class (story: IO class destruction)

* io: getSignerEndpoint lifted up to base class

* Remove inputChecks and authenticate from IO

* wip: kill Combiner and Signer actions

* use handler function (remove IO and Action)

* kill ThresholdService and ResponseLogger classes

* Removes Session and CryptoSession

* Fix typing errors

* fix tests

* Uses httpAgent for http/s connections

* use shouldCheckKeyVerion boolean argument

* fix some tests

* cosmetic cleanup from PR review

* Fixes some tests

* fix error reporting

* fix pnp integration test

* bump combiner version

* fix integrations test

---------

Co-authored-by: alecps <[email protected]>
@soloseng soloseng self-assigned this Sep 29, 2023
@soloseng soloseng requested a review from alecps October 11, 2023 16:26
Copy link
Collaborator

@alecps alecps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/[email protected], @types/[email protected], [email protected], [email protected]

@soloseng soloseng merged commit 8760b09 into main Oct 13, 2023
7 checks passed
@soloseng soloseng deleted the soloseng/odis-cloud-function-gen2 branch October 13, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants