Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take advantage of fixed contract addresses #26

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Take advantage of fixed contract addresses #26

merged 3 commits into from
Oct 27, 2023

Conversation

karlb
Copy link

@karlb karlb commented Oct 25, 2023

  • Simplify code by not reading addresses from Registry
  • Use same addresses for contracts as in the full L2 setup
  • Set FeeHandler as recipient of base fee (FeeHandler/UltraGreen optimism#11)

@palango palango mentioned this pull request Oct 26, 2023
Closed
@karlb karlb marked this pull request as ready for review October 27, 2023 07:28
palango
palango approved these changes Oct 27, 2023
View reviewed changes
Copy link

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that simplifies stuff a lot!

@karlb karlb merged commit 10e5420 into celo2 Oct 27, 2023
6 checks passed
@karlb karlb deleted the karlb/fixed-addresses branch October 27, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palango palango palango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlb @palango