Revert historical rpc #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piersy
force-pushed
the
piersy/revert-historical-rpc
branch
from
9fb0fe6
to
c318d6b
Compare
|
@piersy do we not want to add HistoricalRPCService to debug_traceCall? |
alecps
approved these changes
Oct 3, 2024
Ok merged before I added that, will add it in another PR |
karlb
pushed a commit
that referenced
this pull request
Oct 11, 2024
This reverts the changes made to trigger the historical RPC based on the cel2 block time. (although we retain support for historical execution for debug_traceCall) The reason for this is that there are [tests] in optimism (https://github.com/celo-org/optimism/blob/78d41a3be3c1759e32965a9eb2e69c146eda02b6/op-e2e/op_geth_test.go#L232) that test pre and post time based forks. These test were failing on this PR: * celo-org/optimism#243 The function used to [construct the genesis](https://github.com/celo-org/optimism/blob/78d41a3be3c1759e32965a9eb2e69c146eda02b6/op-chain-ops/genesis/genesis.go#L25) assumes that the time based forks take the time of the L1 start block and sets all time based forks to the L1 start block time. If we set the Cel2Time to the L1 start block time and then try to test some pre fork execution behaviour, the op-geth RPC api will interpret that request as a request that needs to be proxied but in these tests no proxy is set so the tests fail. Previously the test relied on the fact that the bedrock block defaults to zero, and since the old RPC implementation only proxies requests older than bedrock it ensures that no requests need proxying. It turns out that we can use the bedrock block as well, since we always set the bedrock block to be the same block as the migration block. So simply removing the changes made for historical RPC actually works well, and fixes the tests in the aforementioned PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes made to trigger the historical RPC based on the cel2 block time.
The reason for this is that there are [tests] in optimism (https://github.com/celo-org/optimism/blob/78d41a3be3c1759e32965a9eb2e69c146eda02b6/op-e2e/op_geth_test.go#L232) that test pre and post time based forks. These test were failing on this PR:
The function used to construct the genesis assumes that the time based forks take the time of the L1 start block and sets all time based forks to the L1 start block time. If we set the Cel2Time to the L1 start block time and then try to test some pre fork execution behaviour, the op-geth RPC api will interpret that request as a request that needs to be proxied but in these tests no proxy is set so the tests fail.
Previously the test relied on the fact that the bedrock block defaults to zero, and since the old RPC implementation only proxies requests older than bedrock it ensures that no requests need proxying.
It turns out that we can use the bedrock block as well, since we always set the bedrock block to be the same block as the migration block. So simply removing the changes made for historical RPC actually works well, and fixes the tests in the aforementioned PR.