Add currency exchange rates to BlockContext #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlb
force-pushed
the
karlb/fee-currency-exchange-rates
branch
from
8fc76b1
to
f6e145e
Compare
palango
reviewed
Oct 13, 2023
| @@ -49,7 +56,27 @@ func celoGenesisAccounts() map[common.Address]GenesisAccount { | |||
| if err != nil { | |||
| panic(err) | |||
| } | |||
| sortedOraclesBytecodeLinked := bytes.Replace(contracts.SortedOraclesBytecodeRaw, []byte("__$c0b499b413513d0c67e2a6a17d90846cb3$__"), []byte("000000000000000000000000000000000000ce17"), -1) | |||
There was a problem hiding this comment.
Will we have to adapt this every time the bytecode changes?
There was a problem hiding this comment.
I failed at looking up that information. I assume it is something stable like keccak("AddressSortedLinkedListWithMedian") to get a fixed length placeholder.
Celo specific changes should be in separate files from the upstream code wherever possible. Also check for Cel2 flag.
karlb
force-pushed
the
karlb/fee-currency-exchange-rates
branch
from
f6e145e
to
f7fdfb3
Compare
karlb
force-pushed
the
karlb/fee-currency-exchange-rates
branch
from
f7fdfb3
to
13cec5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not add currency specific base fees, as these are implied by the CELO base fee and the exchange rate.
The FeeCurrency is from the unmerged and untested celo-org/optimism#71, but I wanted to include all necessary contracts in one go. We can easily update it later.
The manual initialization of contracts in
core/celo_genesis.gois a bit fiddly, but IMO still better than pulling in additional tooling.Since the fee currency support is incomplete, the e2e testing does not actually test anything at the moment. It provides good examples what to run to check the partial support, though.
Closes celo-org/optimism#58