Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for building image #14

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Workflow for building image #14

merged 1 commit into from
Sep 13, 2023

Conversation

jcortejoso
Copy link
Member

@jcortejoso jcortejoso commented Sep 13, 2023

Build and push container images on every commit (under celo-org fork). Images are pushed to http://us-west1-docker.pkg.dev/blockchaintestsglobaltestnet/dev-images/op-geth):<sha>.

Images are signed with cosign and analyzed by trivy. Trivy reports should be available under this project Security tab.

Copy link

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Building on every push will generate a lot of images quickly. Will hat cause any problems or unreasonable costs?

@jcortejoso jcortejoso merged commit 1d173bb into celo1 Sep 13, 2023
7 checks passed
@jcortejoso jcortejoso deleted the jcortejoso/ci-cd-images branch September 13, 2023 11:07
@lvpeschke
Copy link

Building on every push will generate a lot of images quickly. Will hat cause any problems or unreasonable costs?

The main potential problem I can imagine is builds hogging too many GitHub Actions resources and delaying other workflows.

Regarding the cost, it does scale with the number of images and the size of them, roughly in the following order: scanning, pipeline resources, networking, storage. We do have clean-up automation in place to avoid infinite registry growth. In addition, the overall cost is monitored and currently looks reasonable.

Building on every push is for developer experience convenience - if it doesn't add to it, feel free to reduce the frequency to a level that seems more appropriate.

palango pushed a commit that referenced this pull request Sep 26, 2023
karlb pushed a commit that referenced this pull request Nov 17, 2023
palango pushed a commit that referenced this pull request Jan 31, 2024
karlb pushed a commit that referenced this pull request Feb 20, 2024
palango pushed a commit that referenced this pull request Apr 30, 2024
palango pushed a commit that referenced this pull request May 8, 2024
palango pushed a commit that referenced this pull request May 31, 2024
carterqw2 pushed a commit that referenced this pull request Jun 11, 2024
karlb pushed a commit that referenced this pull request Jul 10, 2024
karlb pushed a commit that referenced this pull request Jul 10, 2024
karlb pushed a commit that referenced this pull request Jul 12, 2024
karlb pushed a commit that referenced this pull request Aug 20, 2024
karlb pushed a commit that referenced this pull request Aug 26, 2024
karlb pushed a commit that referenced this pull request Aug 30, 2024
karlb pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants