Fix stCelo compatibility #11237
Open
Fix stCelo compatibility #11237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahor167
reviewed
Oct 7, 2024
Fix stCelo compatibility
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…-org/celo-monorepo into martinvol/fixValidatorCompatibility
…-org/celo-monorepo into martinvol/fixValidatorCompatibility
|
For stCelo this approach works, but it does not really bring backwards compatibility to all other contracts in the CELO ecosystem. Any contracts that are making use of |
soloseng
reviewed
Oct 7, 2024
| slashingMultiplierResetPeriod = value; | ||
| emit SlashingMultiplierResetPeriodSet(value); |
There was a problem hiding this comment.
Slashing multiplier is no longer used by any L2 contracts. is there a reason for keeping them active?
martinvol
commented
Oct 7, 2024
| @@ -611,7 +613,6 @@ contract Validators is | |||
| * @param validatorAccount The validator to deaffiliate from their affiliated validator group. | |||
| */ | |||
| function forceDeaffiliateIfValidator(address validatorAccount) external nonReentrant onlySlasher { | |||
| allowOnlyL1(); | |||
There was a problem hiding this comment.
TODO probably needs to stay removed #11225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/celo-org/celo-blockchain-planning/issues/642