Updating Core smart contracts to Solidity 0.8

[pahor167]

Description

Updating Core smart contracts to Solidity 0.8

What works:

1. All major core smart contracts are moved to 0.8
2. Foundry build works
3. Truffle build works
4. Foundry tests work

What is yet missing:

• Truffle migration is broken

1. There is problem with linking libraries that are now migrated to 0.8 - Currently it is partly fixed but it needs further investigation for Signers library which is currently causing errors when running truffle tests: yarn build:ts && yarn --cwd packages/protocol test common/

• Anvil devchain migration is broken

1. Again the problem is with libraries that are build in first step of anvil devchain. I tried to update paths but it needs further investigation.

• Since OZ broke storage in AddressSet we need to upgrade AddressSet 0.5 to 0.8 manually rather then use OZ 0.8 AddressSet

struct AddressSet { // Position of the value in the values array, plus 1 because index 0 // means a value is not in the set. mapping (address => uint256) index; address[] values; }

vs

struct AddressSet { Set _inner; }

It seems it was design decision rather than security decision which should allow us to simply update AddressSet from 0.5 to 0.8.

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10538986	Triggered	Generic High Entropy Secret	f5321bf	packages/protocol/scripts/foundry/constants.sh	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	None	0	109 kB	gnsps

🚮 Removed packages: npm/[email protected]

View full report↗︎