Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Big Emigration (ciao sdks) #10829

Merged
merged 18 commits into from
Dec 19, 2023
Merged

The Big Emigration (ciao sdks) #10829

merged 18 commits into from
Dec 19, 2023

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Dec 13, 2023

Description

Removes all of /packages/sdks, packages/cli, etc . These will now live at celo-org/developer-tooling see celo-org/developer-tooling#12 for that diff

This is not the end state of the transition, rather it is just the largest chunk. But its better to be swift rather than have big changes lingering for a long time

Follow-up PRs will

  • upgrade yarn, linting, typescript etc,
  • remove more packages from root packge.json (once i figure out which are actually needed)
  • do more clean up for anything left

Other changes

fixes little issue in pre-push script.
fixes little issue in dev-utils package.json

noteworthy

  • typescript package remains because as soon as we upgrade to eslint-tyescript we can just delete it.
  • dev-utils remains. I think we might move to a separate repo later.

Tested

existing tests

Related issues

Backwards compatibility

Documentation

n/a

Copy link

changeset-bot bot commented Dec 13, 2023

⚠️ No Changeset found

Latest commit: 53dc705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Dec 13, 2023

@aaronmgdr aaronmgdr marked this pull request as ready for review December 13, 2023 12:27
@aaronmgdr aaronmgdr requested review from a team as code owners December 13, 2023 12:27
@aaronmgdr aaronmgdr requested review from a team and lvpeschke December 13, 2023 12:27
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@aaronmgdr
Copy link
Member Author

most of the "failing" tests are those that this pr removes. the other is known to fail from time to time

@aaronmgdr aaronmgdr enabled auto-merge (squash) December 19, 2023 14:26
@aaronmgdr
Copy link
Member Author

since the packages which run the tests are being remove in the pr we need to turn off the requirement that they pass to merge

@lvpeschke Can you help here?

@aaronmgdr aaronmgdr merged commit e9b7eb3 into master Dec 19, 2023
33 checks passed
@aaronmgdr aaronmgdr deleted the aaronmgdr/the-remainer branch December 19, 2023 16:29
@aaronmgdr aaronmgdr mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove sdks + cli from monorepo
2 participants