Soloseng/add-combiner-db #10491
Closed
Soloseng/add-combiner-db #10491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: soloseng <[email protected]>
* bump firebase version * format `minInstances` to number * updated peer dependecy
* enable optional quota bypass during load test. * moved log to better track failed signers * increase the range test sessionID
add metering
* add option to use DEK in loadtest * Added monitoring counter for AuthenticationMethod * randomized phonenumber to avoid replay attempts
This reverts commit be9078f.
|
closing in favor of #10511 that includes mem Cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a database to the combiner to keep a cache of the DEK issuers used to authenticate. This avoids a mandatory call to fullnode to get the DEK.
This implementation uses a SQL database to cache the user accounts, as cloud function are stateless, and there is no guarantee that the cached state will be shared across invocations. More on the topic here...
One alternative option would be to use MemoryStore/Redis to cache the account data.
Tested
Adapted integration test to use the DB
Related issues