Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): bump go to v1.22.4 #425

Merged
merged 1 commit into from
Jun 6, 2024
Merged

feat(go): bump go to v1.22.4 #425

merged 1 commit into from
Jun 6, 2024

Conversation

tty47
Copy link
Contributor

@tty47 tty47 commented Jun 6, 2024

fixes go standard lib vulnerability: #424

Vulnerability #1: GO-2024-2887
    Unexpected behavior from Is methods for IPv4-mapped IPv6 addresses in
    net/netip
  More info: https://pkg.go.dev/vuln/GO-2024-2887
  Standard library
    Found in: net/netip@go1.22.3
    Fixed in: net/netip@go1.22.4
    Example traces found:
Error:       #1: pkg/instance/helper.go:398:29: instance.getFreePortTCP calls net.Listen, which eventually calls netip.Addr.IsLoopback
Error:       #2: pkg/instance/helper.go:398:29: instance.getFreePortTCP calls net.Listen, which eventually calls netip.Addr.IsMulticast
Your code is affected by 1 vulnerability from the Go standard library.
This scan also found 0 vulnerabilities in packages you import and 1
vulnerability in modules you require, but your code doesn't appear to call these
vulnerabilities.
Use '-show verbose' for more details.

Signed-off-by: Jose Ramon Mañes <[email protected]>
@tty47 tty47 requested a review from a team June 6, 2024 07:39
@tty47 tty47 self-assigned this Jun 6, 2024
@tty47 tty47 added bug Something isn't working fix Fix ci CI labels Jun 6, 2024
@tty47
Copy link
Contributor Author

tty47 commented Jun 6, 2024

results: https://github.com/celestiaorg/knuu/actions/runs/9396973684/job/25879205485

Cache is not found
go version go1.22.4 linux/amd64
go env
Run go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.1
go: downloading golang.org/x/mod v0.17.0
go: downloading golang.org/x/tools v0.21.1-0.202405[140](https://github.com/celestiaorg/knuu/actions/runs/9396973684/job/25879205485#step:2:151)24235-59d9797072e7
go: downloading golang.org/x/sync v0.7.0
Run govulncheck -C . -format text ./...
  
No vulnerabilities found.

Copy link
Contributor

coderabbitai bot commented Jun 6, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • go.mod is excluded by !**/*.mod

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tty47 tty47 enabled auto-merge June 6, 2024 10:09
@tty47 tty47 disabled auto-merge June 6, 2024 10:09
@tty47 tty47 merged commit 916884f into main Jun 6, 2024
17 of 18 checks passed
@tty47 tty47 deleted the jose/ci-vul branch June 6, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci CI fix Fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants