-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move defaultLogger to a log directory #421
Conversation
WalkthroughThe recent changes streamline the logging mechanism by replacing custom logger initialization with a standardized default logger setup using Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Client
participant Knuu
participant Logger
Client->>Knuu: New(ctx, opts...)
Knuu->>Logger: log.DefaultLogger()
Logger-->>Knuu: Configured Logger
Knuu-->>Client: *Knuu, error
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- pkg/knuu/knuu.go (4 hunks)
- pkg/log/logger.go (1 hunks)
Additional comments not posted (2)
pkg/knuu/knuu.go (2)
21-21
: Correctly updated import to use the newDefaultLogger
.
104-104
: Proper use ofDefaultLogger
in theNew
function.Verification successful
The verification confirms that the
DefaultLogger
function is defined inpkg/log/logger.go
and is used inpkg/knuu/knuu.go
. There are no remaining references to the olddefaultLogger
.
pkg/log/logger.go
: Defines theDefaultLogger
function.pkg/knuu/knuu.go
: Uses theDefaultLogger
function.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all references to the old `defaultLogger` have been updated to `DefaultLogger`. # Test: Search for the old function usage. Expect: No occurrences. rg --type go $'defaultLogger'Length of output: 28
Script:
#!/bin/bash # Description: Verify the usage of `DefaultLogger` across the codebase. # Test: Search for the usage of `DefaultLogger` and list the occurrences. rg --type go $'DefaultLogger'Length of output: 134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Overview
defaultLogger
function to a log directory and renameDefaultLogger
DefaultLogger
from the other packagesissue:
log
folder #377Summary by CodeRabbit
New Features
Refactor