Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k8s-client): tweak default config #399

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

tty47
Copy link
Contributor

@tty47 tty47 commented May 29, 2024

hello!

adding custom config to the client, with these values, the K8S API can manage the requests

Summary by CodeRabbit

  • Enhancements
    • Improved cluster configuration to support higher throughput and concurrency with increased QPS and Burst settings.

@tty47 tty47 requested a review from a team May 29, 2024 15:38
@tty47 tty47 added the knuu label May 29, 2024
smuu
smuu previously approved these changes May 30, 2024
pkg/k8s/k8s.go Outdated Show resolved Hide resolved
Signed-off-by: Jose Ramon Mañes <[email protected]>
Copy link
Contributor

coderabbitai bot commented May 31, 2024

Walkthrough

The changes enhance the Kubernetes client configuration in pkg/k8s/k8s.go by adding constants to increase the QPS (queries per second) and Burst settings. This modification aims to improve throughput and concurrency when interacting with Kubernetes clusters, whether using in-cluster configuration or a kubeconfig file.

Changes

Files Change Summary
pkg/k8s/k8s.go Added constants CustomQPS (100) and CustomBurst (200). Updated getClusterConfig to utilize these constants for better throughput and concurrency.

Poem

Among the clusters, swift and bright,
Our code now dances in the light.
With QPS and Burst set high,
Kubernetes tasks now swiftly fly.
A rabbit's joy in code's delight,
Speed and grace in every byte. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 74e6413 and 76d74b0.

Files selected for processing (1)
  • pkg/k8s/k8s.go (2 hunks)
Additional comments not posted (2)
pkg/k8s/k8s.go (2)

30-31: The introduction of CustomQPS with a value of 100 is a significant improvement over the default QPS of 5, enhancing client throughput.


33-34: The introduction of CustomBurst with a value of 200 is a substantial improvement over the default Burst of 10, enhancing client concurrency.

pkg/k8s/k8s.go Outdated Show resolved Hide resolved
Signed-off-by: Jose Ramon Mañes <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 76d74b0 and 3a89961.

Files selected for processing (1)
  • pkg/k8s/k8s.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • pkg/k8s/k8s.go

@tty47 tty47 requested review from MSevey and smuu May 31, 2024 13:55
@tty47 tty47 enabled auto-merge May 31, 2024 14:19
@tty47 tty47 requested a review from mojtaba-esk May 31, 2024 14:20
pkg/k8s/k8s.go Show resolved Hide resolved
@tty47 tty47 added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 5bc5c3d Jun 3, 2024
10 of 11 checks passed
@tty47 tty47 deleted the jose/increase-default-client-config branch June 3, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants