-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore!: remove excess blobTx file and add more test coverage (#99)
I forgot to remove the blobTx file when moving it to it's own folder. This PR deletes it and tidies up the imports. I also added a few tests to the marshalling/unmarshalling which weren't previously covered
- Loading branch information
Showing
12 changed files
with
312 additions
and
111 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| package share | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "crypto/rand" | ||
| "testing" | ||
|
|
||
| v1 "github.com/celestiaorg/go-square/v2/proto/blob/v1" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestProtoEncoding(t *testing.T) { | ||
| signer := make([]byte, 20) | ||
| _, err := rand.Read(signer) | ||
| require.NoError(t, err) | ||
| blob, err := NewBlob(RandomNamespace(), []byte{1, 2, 3, 4, 5}, 1, signer) | ||
| require.NoError(t, err) | ||
|
|
||
| blobBytes, err := blob.Marshal() | ||
| require.NoError(t, err) | ||
|
|
||
| newBlob, err := UnmarshalBlob(blobBytes) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, blob, newBlob) | ||
| } | ||
|
|
||
| func TestBlobConstructor(t *testing.T) { | ||
| signer := make([]byte, 20) | ||
| _, err := rand.Read(signer) | ||
| require.NoError(t, err) | ||
|
|
||
| ns := RandomNamespace() | ||
| data := []byte{1, 2, 3, 4, 5} | ||
|
|
||
| // test all invalid cases | ||
| _, err = NewBlob(ns, data, 0, signer) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "share version 0 does not support signer") | ||
|
|
||
| _, err = NewBlob(ns, nil, 0, nil) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "data can not be empty") | ||
|
|
||
| _, err = NewBlob(ns, data, 1, nil) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "share version 1 requires signer of size") | ||
|
|
||
| _, err = NewBlob(ns, data, 128, nil) | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), "share version can not be greater than MaxShareVersion") | ||
| } | ||
|
|
||
| func TestNewBlobFromProto(t *testing.T) { | ||
| namespace := RandomNamespace() | ||
| testCases := []struct { | ||
| name string | ||
| proto *v1.BlobProto | ||
| expectedErr string | ||
| }{ | ||
| { | ||
| name: "valid blob", | ||
| proto: &v1.BlobProto{ | ||
| NamespaceId: namespace.ID(), | ||
| NamespaceVersion: uint32(namespace.Version()), | ||
| ShareVersion: 0, | ||
| Data: []byte{1, 2, 3, 4, 5}, | ||
| }, | ||
| expectedErr: "", | ||
| }, | ||
| { | ||
| name: "invalid namespace version", | ||
| proto: &v1.BlobProto{ | ||
| NamespaceId: namespace.ID(), | ||
| NamespaceVersion: 256, | ||
| ShareVersion: 0, | ||
| Data: []byte{1, 2, 3, 4, 5}, | ||
| }, | ||
| expectedErr: "namespace version can not be greater than MaxNamespaceVersion", | ||
| }, | ||
| { | ||
| name: "empty data", | ||
| proto: &v1.BlobProto{ | ||
| NamespaceId: namespace.ID(), | ||
| NamespaceVersion: 0, | ||
| ShareVersion: 0, | ||
| Data: []byte{}, | ||
| }, | ||
| expectedErr: "blob data can not be empty", | ||
| }, | ||
| { | ||
| name: "invalid namespace ID length", | ||
| proto: &v1.BlobProto{ | ||
| NamespaceId: []byte{1, 2, 3}, | ||
| NamespaceVersion: 0, | ||
| ShareVersion: 0, | ||
| Data: []byte{1, 2, 3, 4, 5}, | ||
| }, | ||
| expectedErr: "invalid namespace", | ||
| }, | ||
| { | ||
| name: "valid blob with signer", | ||
| proto: &v1.BlobProto{ | ||
| NamespaceId: namespace.ID(), | ||
| NamespaceVersion: 0, | ||
| ShareVersion: 1, | ||
| Data: []byte{1, 2, 3, 4, 5}, | ||
| Signer: bytes.Repeat([]byte{1}, SignerSize), | ||
| }, | ||
| expectedErr: "", | ||
| }, | ||
| { | ||
| name: "invalid signer length", | ||
| proto: &v1.BlobProto{ | ||
| NamespaceId: namespace.ID(), | ||
| NamespaceVersion: 0, | ||
| ShareVersion: 1, | ||
| Data: []byte{1, 2, 3, 4, 5}, | ||
| Signer: []byte{1, 2, 3}, | ||
| }, | ||
| expectedErr: "share version 1 requires signer of size", | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| blob, err := NewBlobFromProto(tc.proto) | ||
| if tc.expectedErr != "" { | ||
| require.Error(t, err) | ||
| require.Contains(t, err.Error(), tc.expectedErr) | ||
| } else { | ||
| require.NoError(t, err) | ||
| require.NotNil(t, blob) | ||
| require.Equal(t, tc.proto.NamespaceId, blob.Namespace().ID()) | ||
| require.Equal(t, uint8(tc.proto.NamespaceVersion), blob.Namespace().Version()) | ||
| require.Equal(t, uint8(tc.proto.ShareVersion), blob.ShareVersion()) | ||
| require.Equal(t, tc.proto.Data, blob.Data()) | ||
| require.Equal(t, tc.proto.Signer, blob.Signer()) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.