-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add new otel links and grafana #1788
Conversation
WalkthroughThe pull request includes updates to two documentation files related to the Celestia node metrics and Mainnet Beta. The changes primarily involve modifying endpoint URLs for the metrics configurations in the Changes
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
gm are these links ready yet @celestiaorg/devops ? |
should this dashboard be populated yet? is this good to merge? cc: @sysrex https://grafana.celestia.dev/d/caaeabfb-33c5-45fd-b5e9-867f5f34ad57/public-bootstrappers?orgId=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
how-to-guides/celestia-node-metrics.md (1)
Line range hint
41-51
: Consider adding Grafana dashboard linksSince this PR includes Grafana-related changes (as mentioned in the PR objectives) and there's a reference to viewing metrics on a Grafana dashboard, consider adding a link to the Grafana dashboard (https://grafana.celestia.dev/d/caaeabfb-33c5-45fd-b5e9-867f5f34ad57/public-bootstrappers) in this documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
how-to-guides/celestia-node-metrics.md
(2 hunks)how-to-guides/mainnet.md
(1 hunks)
🔇 Additional comments (3)
how-to-guides/celestia-node-metrics.md (2)
41-41
: Verify the new Mainnet Beta metrics endpoint
Please confirm that otel.lunar.celestia.dev
is the correct and active endpoint for Mainnet Beta metrics collection.
51-51
: Verify the new Mocha testnet metrics endpoint
Please confirm that otel.mocha.celestia.dev
is the correct and active endpoint for Mocha testnet metrics collection.
how-to-guides/mainnet.md (1)
253-253
: Verify Grafana dashboard functionality and enhance context
The Grafana dashboard link has been updated, but there are a few considerations:
- Based on the PR comments, please verify if this dashboard is ready for public access and properly populated with data.
- Consider adding a brief description of what metrics users can expect to see in this dashboard to set proper expectations.
Consider adding context like this:
-[Grafana dashboard](https://grafana.celestia.dev/d/caaeabfb-33c5-45fd-b5e9-867f5f34ad57/public-bootstrappers?orgId=1&refresh=5s)
+[Grafana dashboard](https://grafana.celestia.dev/d/caaeabfb-33c5-45fd-b5e9-867f5f34ad57/public-bootstrappers?orgId=1&refresh=5s)
+which displays key metrics such as uptime, response times, and health status of the DA bootstrapper nodes
The
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Overview
Summary by CodeRabbit