Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add direct links to gov params for blob.GasPerBlobByte and auth.TxSizeCostPerByte #1363

Merged
merged 2 commits into from
Jan 16, 2024
Merged

feat: add direct links to gov params for blob.GasPerBlobByte and auth.TxSizeCostPerByte #1363

merged 2 commits into from
Jan 16, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Jan 12, 2024 •
edited
Loading

Overview

Problem

Variables are not accurate, based on governance params.

Currently Should be
GasCostPerBlobByte blob.GasPerBlobByte
GasCostPerTransactionByte auth.TxSizeCostPerByte

Solution

Edit documentation to match blob.GasPerBlobByte and auth.TxSizeCostPerByte to be more accurate.

PREVIEW

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-16 16:39 UTC

@jcstein jcstein requested review from evan-forbes and rootulp and removed request for evan-forbes January 12, 2024 23:32
@jcstein jcstein marked this pull request as ready for review January 12, 2024 23:32
@jcstein jcstein self-assigned this Jan 12, 2024
@jcstein jcstein added the documentation Improvements or additions to documentation label Jan 12, 2024
rootulp
rootulp approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh!

developers/submit-data.md Outdated Show resolved Hide resolved
@jcstein jcstein merged commit 465357e into main Jan 16, 2024
2 checks passed
@jcstein jcstein deleted the jcs/update-blob.GasPerBlobByte branch January 16, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

Assignees

@jcstein jcstein

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcstein @rootulp