fix(header)!: tendermint compatible json marshall #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
zvolin
changed the title
zvolin
force-pushed
the
fix/tendermint-compatible-extended-header
branch
from
c354dd2
to
341fdaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/api-breaks #3928 +/- ##
=====================================================
Coverage ? 45.20%
=====================================================
Files ? 307
Lines ? 21802
Branches ? 0
=====================================================
Hits ? 9855
Misses ? 10876
Partials ? 1071 ☔ View full report in Codecov by Sentry. |
cristaloleg
reviewed
Nov 12, 2024
Wondertan
reviewed
Nov 12, 2024
Wondertan
approved these changes
Nov 12, 2024
renaynay
approved these changes
Nov 13, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3918
Please note: this PR is BREAKING as header encoding has changed.