Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github/workflows): attempt to fix releaser workflow so it runs on tags/branches not just main #3834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Oct 9, 2024

Attempt to fix CI release workflow 😬

@renaynay renaynay added ci:actions kind:fix Attached to bug-fixing PRs labels Oct 9, 2024
@renaynay renaynay self-assigned this Oct 9, 2024
@@ -4,6 +4,9 @@ on:
push:
branches:
- main
- '**' # This allows the workflow to trigger on any branch
tags:
- 'v*.*.*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you were looking for something else https://regex101.com/r/GO0uEm/1

Maybe just v.* ? as in #3787 (shiiit, should be v.* in the mentioned PR 😬 )

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.41%. Comparing base (2469e7a) to head (ea4202f).
Report is 338 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3834      +/-   ##
==========================================
+ Coverage   44.83%   46.41%   +1.57%     
==========================================
  Files         265      314      +49     
  Lines       14620    18140    +3520     
==========================================
+ Hits         6555     8419    +1864     
- Misses       7313     8702    +1389     
- Partials      752     1019     +267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:actions kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants