feat!: unify the blob.Proof and the CommitmentProof #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
rach-id
commented
Oct 7, 2024
| }, | ||
| expectedResult: func(res interface{}, err error) { | ||
| require.NoError(t, err) | ||
| // Question for reviwers: for the case of included, it's here made not to return an error |
| @@ -289,7 +288,9 @@ func TestBlobService_Get(t *testing.T) { | |||
| }, | |||
| expectedResult: func(res interface{}, err error) { | |||
| require.Error(t, err) | |||
| require.ErrorIs(t, err, ErrInvalidProof) | |||
| // Question for reviewers: same for here, we're returning exactly, ErrInvalidProof. | |||
rach-id
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature_branch_blob_proof #3821 +/- ##
============================================================
Coverage ? 46.83%
============================================================
Files ? 313
Lines ? 18092
Branches ? 0
============================================================
Hits ? 8474
Misses ? 8602
Partials ? 1016 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3516 and #3582
Note: added couple notes for reviewers concerning the error handling