Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: a simple e2e test with knuu #3795

Draft
wants to merge 3 commits into
base: feature_branch_app_v3
Choose a base branch
from

Conversation

mojtaba-esk
Copy link
Member

This PR proposes to have a simple e2e test for celestia-node with knuu.
The main purpose of this PR is to show how to use knuu for e2e tests.

@github-actions github-actions bot added the external Issues created by non node team members label Oct 2, 2024
@mojtaba-esk mojtaba-esk added the e2e e2e testing related label Oct 2, 2024
@mojtaba-esk
Copy link
Member Author

currently the following error is thrown and the progress is blocked due to that:

$ make test-e2e 
--> Running end to end tests
go run ./test/e2e 
2024/10/02 18:16:03 proto: duplicate proto type registered: celestia.core.v1.da.DataAvailabilityHeader
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.ShareProof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.RowProof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.NMTProof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.proof.Proof
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.tx.TxStatusRequest
2024/10/02 18:16:04 proto: duplicate proto type registered: celestia.core.v1.tx.TxStatusResponse
panic: error with code 1 is already registered: "invalid signal version because signal version can not be less than the current version"

goroutine 1 [running]:
cosmossdk.io/errors.RegisterWithGRPCCode({0x314d082, 0x6}, 0x1, 0x2, {0x325ebed, 0x56})
	/home/moji/go/pkg/mod/cosmossdk.io/[email protected]/errors.go:43 +0x265
cosmossdk.io/errors.Register(...)
	/home/moji/go/pkg/mod/cosmossdk.io/[email protected]/errors.go:35
github.com/celestiaorg/celestia-app/v3/x/signal/types.init()
	/home/moji/go/pkg/mod/github.com/celestiaorg/celestia-app/[email protected]/x/signal/types/errors.go:8 +0x45
exit status 2
make: *** [Makefile:158: test-e2e] Error 1

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 532 lines in your changes missing coverage. Please review.

Project coverage is 45.13%. Comparing base (2469e7a) to head (53d8fc5).
Report is 321 commits behind head on main.

Files with missing lines Patch % Lines
test/e2e/testnet/node.go 0.00% 124 Missing ⚠️
test/e2e/testnet/instance_options.go 0.00% 107 Missing ⚠️
test/e2e/testnet/status.go 0.00% 86 Missing ⚠️
test/e2e/simple.go 0.00% 64 Missing ⚠️
test/e2e/testnet/testnet.go 0.00% 64 Missing ⚠️
test/e2e/testnet/helper.go 0.00% 42 Missing ⚠️
test/e2e/main.go 0.00% 28 Missing ⚠️
test/e2e/testnet/executor.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3795      +/-   ##
==========================================
+ Coverage   44.83%   45.13%   +0.30%     
==========================================
  Files         265      322      +57     
  Lines       14620    18625    +4005     
==========================================
+ Hits         6555     8407    +1852     
- Misses       7313     9201    +1888     
- Partials      752     1017     +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojtaba-esk mojtaba-esk force-pushed the mojtaba/simple-e2e-test-with-knuu branch from 5992d50 to 2134cd6 Compare October 8, 2024 08:01
@mojtaba-esk mojtaba-esk changed the base branch from main to feature_branch_app_v3 October 8, 2024 08:12
@mojtaba-esk
Copy link
Member Author

Update: by pointing to the feature_branch_app_v3 the issue of app version conflict is resolved.

@mojtaba-esk
Copy link
Member Author

Update: since we need to activate Minio and probably some other options for the node tests, we need to wait for this PR in the celestia-app repo to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e e2e testing related external Issues created by non node team members kind:chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants