-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!(share): integrate new Namespace type #2388
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
+ Coverage 50.68% 53.07% +2.38%
==========================================
Files 157 156 -1
Lines 9935 9915 -20
==========================================
+ Hits 5036 5262 +226
+ Misses 4456 4199 -257
- Partials 443 454 +11
|
09dd716
to
d4bdcd2
Compare
Now the PR is properly rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gigantic work, thank you for this!
- Not sure how this test is passing, when it is clearly broken. Pls take a look:
share/availability/light/availability_test.go:162
randNID := root.RowRoots[(len(root.RowRoots)-1)/2][:8]
- There are few places that depend on appconsts.NamespaceSize, that could use on share.NamespaceSize instead.
Thank you for the great review @walldiss! |
47e95dc
to
bce5a03
Compare
Rebased on main to resolve a conflict |
8f379d2
to
4d87ba1
Compare
a793715
to
07c3ec8
Compare
Rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally
Notable Changes
namespace.ID
toshare.Namespace
share -> share/ipld
toshare/ipld -> share
sharetest
pkg for share related testing utilitiesedstest
pkg for eds related testing utilitiesFollow-ups
blobtest
pkg to generate node's blob typeRefs
nID
tonamespace
where applicable #2301share.MaxSquareSize and ipld.MaxSquareSize
to share/eds #2309