chore: extract buf version #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TropicalDog17
requested review from
rootulp and
ninabarbakadze
and removed request for
a team
rootulp
previously approved these changes
Apr 28, 2024
Makefile
Outdated
| @@ -10,6 +10,7 @@ BUILD_FLAGS = -mod=readonly -ldflags "$(LD_FLAGS)" | |||
| HTTPS_GIT := https://github.com/cometbft/cometbft.git | |||
| CGO_ENABLED ?= 0 | |||
|
|
|||
| BUF_VERSION := v1.29.0 | |||
There was a problem hiding this comment.
Thanks! Out of curiosity, why v1.29.0 instead of latest release?
Suggested change
| BUF_VERSION := v1.29.0 | |
| BUF_VERSION := v1.31.0 |
There was a problem hiding this comment.
Yeah I use the version mentioned here, I guess using latest release is better.
There was a problem hiding this comment.
Oh I see, yea if latest doesn't cause any issues then let's bump to latest.
Co-authored-by: Rootul P <[email protected]>
rootulp
approved these changes
Apr 28, 2024
rootulp
requested review from
rach-id and
evan-forbes
and removed request for
ninabarbakadze
rach-id
approved these changes
May 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2024
## Description Closes #1253 #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Rootul P <[email protected]> (cherry picked from commit b67d79e) # Conflicts: # Makefile
3 tasks
cmwaters
pushed a commit
that referenced
this pull request
Jul 30, 2024
Closes #1253 - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Rootul P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1253
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments