fix(lint): golang-client lint errors (backport #3924) #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> Closes #3919 ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> Fix the lint errors of golangci-lint. Merge this [PR](#3923) to this branch. (cherry picked from commit 363a8c5)
mergify
bot
requested review from
rach-id,
evan-forbes and
a team
as code owners
rach-id
reviewed
Sep 30, 2024
There was a problem hiding this comment.
@kobakaku would you be interested in fixing: https://github.com/celestiaorg/celestia-app/actions/runs/11109866098/job/30866227873?pr=3925 in this PR too?
|
golangci-lint is failing: https://github.com/celestiaorg/celestia-app/actions/runs/11109866098/job/30866227873?pr=3925#step:5:33 |
|
@rach-id |
Merged
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> Fix the lint errors of this [PR](#3925).
celestia-bot
requested review from
a team and
cmwaters
and removed request for
a team
rach-id
approved these changes
Oct 2, 2024
rootulp
approved these changes
Oct 2, 2024
staheri14
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3919
Overview
Fix the lint errors of golangci-lint.
Merge this PR to this branch.
This is an automatic backport of pull request #3924 done by Mergify.