fix export app-version

ParamStoreKeyVersionParams key was never set in paramStore. This forces storage of app-version

app/app.go

@@ -771,13 +771,3 @@ func initParamsKeeper(appCodec codec.BinaryCodec, legacyAmino *codec.LegacyAmino
 
 	return paramsKeeper
 }
-
-func (app *App) InitializeAppVersion(ctx sdk.Context) {
-	appVersion := app.GetAppVersionFromParamStore(ctx)
-	if appVersion == 0 {
-		// if the param store does not have an app version set, default to v1
-		app.SetAppVersion(ctx, v1)
-	} else {
-		app.SetAppVersion(ctx, appVersion)
-	}
-}

app/export.go

@@ -19,7 +19,13 @@ func (app *App) ExportAppStateAndValidators(forZeroHeight bool, jailAllowedAddrs
 		return servertypes.ExportedApp{}, err
 	}
 
-	app.InitializeAppVersion(ctx)
+	versionToInit := v1
+	if app.LastBlockHeight() >= app.upgradeHeightV2 {
+		versionToInit = v2
+	}
+	app.SetInitialAppVersionInConsensusParams(ctx, versionToInit)
+	app.SetAppVersion(ctx, versionToInit)
+
 	if !app.IsSealed() {
 		app.mountKeysAndInit(app.AppVersion())
 	}

app/test/export_test.go

@@ -33,7 +33,7 @@ func TestExportAppStateAndValidators(t *testing.T) {
 		require.NoError(t, err)
 		assert.NotNil(t, exported)
 		// TODO: the following assertion is commented out because the exported app does not populate consensus params.version
-		// assert.Equal(t, uint64(2), exported.ConsensusParams.Version.AppVersion)
+		assert.Equal(t, uint64(2), exported.ConsensusParams.Version.AppVersion)
 	})
 }