fix: make the code clearer for postServiceAction

sdk/client.go

@@ -92,12 +92,13 @@ func (c *Client) postServiceAction(resPath string, req interface{}) error {
 	if resErr != nil && resp == nil {
 		return fmt.Errorf("postResource: %w", resErr)
 	}
-	msg := api.MetaMessage{}
 
-	if err := json.Unmarshal(resp, &msg); err != nil {
-		// if the response is not a MetaMessage, it's probably a success message
-		// Therefore we just return the original error from the request
-		return resErr
+	msg := api.MetaMessage{}
+	if err := json.Unmarshal(resp, &msg); err == nil {
+		return Error{Message: msg}
 	}
-	return Error{Message: msg}
+
+	// if the response is not a MetaMessage, it's probably a success message
+	// Therefore we just return the original error from the request which is nil on success
+	return resErr
 }

sdk/sdk_test.go

@@ -42,7 +42,7 @@ func Test_SDK_Client_GetResource_HTTPError(t *testing.T) {
 
 	client := NewClient(mockServer.URL)
 	res, err := client.getResource("/error")
-	assert.Nil(t, res)
+	assert.Empty(t, res)
 	assert.Error(t, err)
 }
 
@@ -113,7 +113,7 @@ func Test_SDK_Client_PostResource_HTTPError(t *testing.T) {
 		client := NewClient(mockServer.URL)
 		res, err := client.postResource("/error", nil)
 
-		assert.Nil(t, res)
+		assert.Empty(t, res)
 		assert.Error(t, err)
 	}
 }