fix: better err propagation for stop & start service

celestiaorg · Dec 11, 2023 · b065de7 · b065de7
1 parent 456bae4
commit b065de7
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/api/v1/net_services_utils.go b/api/v1/net_services_utils.go
@@ -22,10 +22,15 @@ func netServiceStart(resp http.ResponseWriter, ns *netRestrictService, ifaceName
 	}
 
 	if err := ns.Start(ifaceName); err != nil {
+		slug := SlugServiceStartFailed
+		if err == ErrServiceNotInitialized {
+			slug = SlugServiceNotInitialized
+		}
+
 		sendJSONError(resp,
 			MetaMessage{
 				Type:    APIMetaMessageTypeError,
-				Slug:    SlugServiceStartFailed,
+				Slug:    slug,
 				Title:   "Service start failed",
 				Message: err.Error(),
 			},
@@ -42,10 +47,15 @@ func netServiceStop(resp http.ResponseWriter, ns *netRestrictService) error {
 	}
 
 	if err := ns.Stop(); err != nil {
+		slug := SlugServiceStopFailed
+		if err == ErrServiceNotStarted {
+			slug = SlugServiceNotStarted
+		}
+
 		sendJSONError(resp,
 			MetaMessage{
 				Type:    APIMetaMessageTypeError,
-				Slug:    SlugServiceStopFailed,
+				Slug:    slug,
 				Title:   "Service stop failed",
 				Message: err.Error(),
 			},