add periodic_task_name to headers #819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngryUbuntuNerd
force-pushed
the
periodic_task_name
branch
from
79d7360
to
8625450
Compare
|
closed as its a duplicate of #812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with
periodic_task_namewhen using RabbitMQ, in that the field does not appear in the RabbitMQ message as a top-level-property - which is where it is sent in the process by django-celery-beat. This does work when using other Celery message brokers, i.e. Redis.The underlying reason is that
periodic_task_nameis not in the list of allowed top-level-properties for AMQP (see amqp sourcecode) so it gets discarded when passed over to RabbitMQ.This PR addresses the issue by additionally sending it as a message header.
See also celery/django-celery-results#376