Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IntervalSchedule to use a custom schedule type. #697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow IntervalSchedule to use a custom schedule type. #697

wants to merge 1 commit into from

Conversation

sdrabblescripta
Copy link

No description provided.

auvipy
auvipy requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need tests to verify the proposed changes

@sdrabblescripta
Copy link
Author

Of course, and I planned on adding them but I'm unable to run the current test suite so if you could provide advice on how to do that successfully (tox -e py38 returns a bunch of errors) then I'll be happy to add new tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrabblescripta @auvipy