Replace "volid" with "vol_id" throughout ORANGE

[elliottbiondo]

This MR updates all files within ORANGE to use the form "vol_id" for variable names instead of "volid", for consistency with other opaque IDs such as universe_id, transform_id, level_id, etc.

[github-actions]

Test summary

 3 371 files   5 194 suites   3m 54s ⏱️
 1 577 tests  1 549 ✅ 28 💤 0 ❌
17 384 runs  17 318 ✅ 66 💤 0 ❌

Results for commit fa61437.

♻️ This comment has been updated with latest results.

[elliottbiondo]

@sethrj RTR

[sethrj]

Looks great. Do you want to do the same for univ_id, trans_id, ...? I think it would be a nice touch. Also like we have uid in there, there are a couple of vid for vol_id.

[elliottbiondo]

Yeah I can do that too. I wasn't sure how far too go. I am thinking:

surf_id,
trans_id,
univ_id,

but only for local variable names. If I start changing APIs (geo.volume_id() to geo.vol_id()) the changes become more invasive. I also don't want to mess but the .jsons.

[sethrj]

Yes, agreed. I think it's ok (and often better?) for API names to be spelled out. In fact, I read/saw recently a guideline that said the more global an identifier's scope, the longer/more descriptive the name should be; and conversely very local variables can be very short (think i in an inner loop, or v for volume id in a 3-line loop).