Extend BIH capabilities for intersection operations #1479
Conversation
Test summary 3 401 files 5 253 suites 3m 52s ⏱️ Results for commit 4adf145. ♻️ This comment has been updated with latest results. |
elliottbiondo
force-pushed
the
bih_intersect3
branch
3 times, most recently
from
ed047f4
to
c768aa4
Compare
elliottbiondo
force-pushed
the
bih_intersect3
branch
from
c768aa4
to
089bde7
Compare
elliottbiondo
changed the title
elliottbiondo
added
orange
|
@sethrj this is ready. Probably better to review this one first, then I will do the vol_id + others one. |
| { | ||
| Real3 pos; | ||
| Real3 dir; | ||
| }; |
There was a problem hiding this comment.
I don't think this is a good idea; it forces a copy of the data and increases register pressure. If anything, make the data members Real3 const& and pass Ray by value.
| previous_node = exchange( | ||
| current_node, | ||
| this->next_node( | ||
| current_node, previous_node, ray, intersection.distance)); |
| * nearer intersection with an edge bbox or volume bbox. This is because is is | ||
| * possible to have a ray that interects with a volume's bbox, but not the | ||
| * volume itself. | ||
| * |
There was a problem hiding this comment.
Can you add a brief synopsis of the expected form of the F template function? (i.e. real_type(*)(VolumeId), it should return the distance to the intersection with the volume.)
| { | ||
| for (auto id : view_.inf_volids()) | ||
| { | ||
| auto intersection = visit_vol(id); |
There was a problem hiding this comment.
Since we can often reduce the cost of an intersection by passing a "maximum search distance", (i.e. if we know the closest volume is nearby we don't need to evaluate logic if the nearest surface is further than that) I think the visit function should include a "minimum" as an argument, just like the SimpleUnitTracker intersect does.
This MR creates the
BIHIntersectingVolFinderclass which is used to find the surface that a ray intersects with first, and the corresponding distance to this surface. This is done using a traversal strategy that is distinct fromBIHEnclosingVolFinder, as is documented in their respective top-level doc strings. In a subsequent MR, this will be "hooked up" for use in background volumes.