Simplify UnitProto after building a CsgUnit #1415
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esseivaju
added
enhancement
esseivaju
force-pushed
the
simplify-unitproto
branch
from
8e23c9f
to
b2a0c4c
Compare
sethrj
reviewed
Sep 20, 2024
| /*! | ||
| * Result of a DeMorgan simplification. | ||
| */ | ||
| struct DeMorganSimplifierResult |
There was a problem hiding this comment.
This could be a general "simplification" mapping. Perhaps it should be moved to CsgTree itself (imagine a function that runs "simplify" on the tree itself)?
| struct DeMorganSimplifierResult | ||
| { | ||
| CsgTree tree; | ||
| std::vector<NodeId> equivalent_nodes; |
There was a problem hiding this comment.
Old node ID is the index, new node ID is the value? (Maybe new_nodes?)
| @@ -391,7 +391,7 @@ TEST_F(CsgTreeUtilsTest, transform_negated_joins) | |||
| auto s1 = this->insert(Surface{S{1}}); | |||
| auto n0 = this->insert(Negated{s1}); | |||
| auto j0 = this->insert(Joined{op_and, {s0, n0}}); | |||
| auto simplified = transform_negated_joins(tree_); | |||
| auto simplified = transform_negated_joins(tree_).tree; | |||
There was a problem hiding this comment.
You should test the mapping result too...
Test summary 3 279 files 5 076 suites 3m 31s ⏱️ Results for commit 4f8f07f. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for validation purposes, eventually I think we should only use the transformed
CsgTreeon GPU.Requires #1418