Merge pull request #64 from cel3ntano/labels-fix

photo-sizes
cel3ntano · Jun 18, 2024 · 0e09e54 · 0e09e54
2 parents ebbb159 + faf2b18
commit 0e09e54
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 23 deletions.
diff --git a/src/js/projects.js b/src/js/projects.js
@@ -176,6 +176,8 @@ function loadProjects() {
  srcset="${imgSrcSet}"
  src="${imgSrc}"
  alt="${alt}"
+ width="830"
+ height="480"
  />
  <p class="project-text">${tech}</p>
  <div class="projects-wrap">

diff --git a/src/partials/about.html b/src/partials/about.html
@@ -5,42 +5,30 @@ <h2 class="about-title">
  </h2>
  <div class="about-content about-img-decor change-them">
  <div class="about-img">
- <img
- class="benef-peach change-them"
- srcset="
+ <img class="benef-peach change-them" width="384" height="448" srcset="
  ./img/about/loid-dsk-2x-peach-min.jpg 2560w,
  ./img/about/loid-dsk-1x-peach-min.jpg 1280w,
  ./img/about/loid-tab-2x-peach-min.jpg 1536w,
  ./img/about/loid-tab-1x-peach-min.jpg 768w,
  ./img/about/loid-mob-2x-peach-min.jpg 640w,
  ./img/about/loid-mob-1x-peach-min.jpg 320w
- "
- sizes="
+ " sizes="
  (min-width: 1280px) 1280px,
  (min-width: 768px) 768px,
  (max-width: 767px) 320px
- "
- src="./img/about/loid-dsk-1x-peach-min.jpg"
- alt="Lloyd Jefferson"
- />
- <img
- class="benef-blue change-them"
- srcset="
+ " src="./img/about/loid-dsk-1x-peach-min.jpg" alt="Lloyd Jefferson" />
+ <img class="benef-blue change-them" width="384" height="448" srcset="
  ./img/about/loid-dsk-2x-blue-min.jpg 2560w,
  ./img/about/loid-dsk-1x-blue-min.jpg 1280w,
  ./img/about/loid-tab-2x-blue-min.jpg 1536w,
  ./img/about/loid-tab-1x-blue-min.jpg 768w,
  ./img/about/loid-mob-2x-blue-min.jpg 640w,
  ./img/about/loid-mob-1x-blue-min.jpg 320w
- "
- sizes="
+ " sizes="
  (min-width: 1280px) 1280px,
  (min-width: 768px) 768px,
  (max-width: 767px) 320px
- "
- src="../img/about/loid-dsk-1x-blue-min.jpg"
- alt="Lloyd Jefferson"
- />
+ " src="./img/about/loid-dsk-1x-blue-min.jpg" alt="Lloyd Jefferson" />
  </div>
  <div class="bio-text">
  <h3 class="about-subtitle">bio</h3>
@@ -90,4 +78,4 @@ <h3 class="about-subtitle">role</h3>
  </div>
  </div>
  </div>
-</section>
+</section>
diff --git a/src/partials/header.html b/src/partials/header.html
@@ -7,7 +7,8 @@ <h2 class="header-title">
  </a>
  </h2>
  <label for="theme-btn" class="theme">
- <input type="checkbox" name="switchTheme" id="theme-btn" class="visually-hidden theme-btn" />
+ <input type="checkbox" name="switchTheme" id="theme-btn" class="visually-hidden theme-btn"
+ aria-label="Theme switcher" />
  <span class="switch-theme"></span>
  </label>
  <button class="switch-open-burger active-btn" data-img="icon-open-burger" aria-label="Open menu">
@@ -35,7 +36,8 @@ <h2 class="header-title">
  </ul>
  </nav>
  </div>
- <a href="#hero" class="up-link up-link-active"><svg class="icon icon-up-arrow" width="30" height="38">
+ <a href="#hero" class="up-link up-link-active" aria-label="Scroll up"><svg class="icon icon-up-arrow" width="30"
+ height="38">
  <use class="inform-item-icon" href="./img/icons.svg#icon-up-arrow"></use>
  </svg>
  </a>

diff --git a/src/partials/hero.html b/src/partials/hero.html
@@ -12,15 +12,15 @@ <h1 class="hero-title"><span class="hero-title-upper">Hello, I am</span><span cl
  srcset="./img/hero/dude-tab-pink.png 1x, ./img/hero/dude-tab-2x-pink.png 2x">
  <source media="(max-width: 767px)"
  srcset="./img/hero/dude-mob-pink.png 1x, ./img/hero/dude-mob-2x-pink.png 2x">
- <img src="./img/hero/dude-pink.png" alt="Red Dude">
+ <img src="./img/hero/dude-pink.png" alt="Red Dude" width="384" height="396">
  </picture>
  <picture class="hero-image benef-blue change-them">
  <source media="(min-width: 1280px)" srcset="./img/hero/dude-blue.png 1x, ./img/hero/dude-2x-blue.png 2x">
  <source media="(min-width: 768px)"
  srcset="./img/hero/dude-tab-blue.png 1x, ./img/hero/dude-tab-2x-blue.png 2x">
  <source media="(max-width: 767px)"
  srcset="./img/hero/dude-mob-blue.png 1x, ./img/hero/dude-mob-2x-blue.png 2x">
- <img src="./img/hero/dude-blue.png" alt="Red Dude">
+ <img src="./img/hero/dude-blue.png" alt="Red Dude" width="384" height="396">
  </picture>
  </div>
  <div class="hero-social">