-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build.ps1: Use minimal distribution instead of standard distribution #57
Conversation
Thanks. @merceyz, have you tested building with this change and verified that it works as expected? |
No, i'm unable to successfully run the build script due to me having VS2017. Also before this PR is merged the CEF version needs to be updated |
True. So let's wait on it a while. Thanks anyway, a good start! |
I can confirm that it does not work yet. The problem is that the CMakeList.txt contains lines with |
That's interesting actually! I used a similar approach in my #62 hackish branch, and it did actually work using the minimal distrib. (note: x86 only, I haven't yet built CEF successfully on x64...) |
It was fixed in https://bitbucket.org/chromiumembedded/cef/commits/cd6b88f7e4bd455445a7619824c2109904be97c5 Which is why I said
|
Ah, ... CEF was updated 3 days ago to fix this very issue. That is a “recent” version indeed ;) |
I noted that the CEF 63 binaries are now published. We might as well start doing some of the plumbing for an eventual CefSharp 63.0.0 release. (The README.txt diff is somewhat more noisy than expected, since I copied in the file from the minimal distribution instead. We are migrating to use that: #57)
Merged with commit a4a8434 |
Reverted changes with commit d654b9b Switching to the |
Changes:
Download the minimal distribution instead of standard distribution to speed up the total build time
Resolves #56