Further demonstration of issue: https://github.com/cefsharp/CefSharp/issues/4621 #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified Google test to replicate this issue: cefsharp#4621
# Conflicts: # CefSharp.Test/OffScreen/OffScreenBrowserTests.cs
Formatted and rewritten OffScreenBrowserTests.cs to include a new test which mimics this issue: cefsharp#4741
New test to mimic issue cefsharp#4621 where isolate-origins settings does not help.
1 task
|
❌ Build CefSharp 123.0.60-CI4976 failed (commit 5cafd9f71a by @nebojsasandin) |
amaitland
added a commit
that referenced
this pull request
May 6, 2024
- They will only run locally for now #4771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was concluded that the bypass for issue: #4621 can be resolved by using:
settings.CefCommandLineArgs.Add("isolate-origins", "https://accounts.google.com,https://chrome.google.com,https://chromewebstore.google.com,https://mail.google.com,https://www.google.com,https://google.com");...however, there's a new test which demonstrates that this workaround isn't always helpful.
GoogleSearchToGoogleAccountsBreaksJS() test method works with the workaround method, however: GoogleSearchToGmailBreaksJS() test method does not work.