CastingDiscovery: fix snprintf warning

snprintf appends a null terminator, as does strcat, so both buffers need to be upsized by 1 to accommodate that.
cecille · Oct 2, 2023 · cd07de2 · cd07de2
1 parent 6047fbb
commit cd07de2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/examples/tv-casting-app/tv-casting-common/core/CastingPlayer.h b/examples/tv-casting-app/tv-casting-common/core/CastingPlayer.h
@@ -45,7 +45,7 @@ const int kIdMaxLength   = chip::Dnssd::kHostNameMaxLength + kPortMaxLength;
 class CastingPlayerAttributes
 {
 public:
-    char id[kIdMaxLength]                                  = {};
+    char id[kIdMaxLength + 1]                              = {};
     char deviceName[chip::Dnssd::kMaxDeviceNameLen + 1]    = {};
     char hostName[chip::Dnssd::kHostNameMaxLength + 1]     = {};
     char instanceName[chip::Dnssd::kHostNameMaxLength + 1] = {};

diff --git a/examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp b/examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp
@@ -81,7 +81,7 @@ void DeviceDiscoveryDelegateImpl::OnDiscoveredDevice(const chip::Dnssd::Discover
     CastingPlayerAttributes attributes;
     strcpy(attributes.id, nodeData.resolutionData.hostName);
 
-    char port[kPortMaxLength] = {};
+    char port[kPortMaxLength + 1] = {};
     snprintf(port, sizeof(port), "%u", nodeData.resolutionData.port);
     strcat(attributes.id, port);