-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tie to the custom docker network for the devcontainers #1986
Changes from 6 commits
7c00238
af937e6
6b24fef
352657e
542fcab
b947601
526b907
e9a2e3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
version: '3' | ||
services: | ||
# Update this to the name of the service you want to work with in your docker-compose.yml file | ||
notify-admin: | ||
build: | ||
context: .. | ||
dockerfile: .devcontainer/Dockerfile | ||
# If you want add a non-root user to your Dockerfile, you can use the "remoteUser" | ||
# property in devcontainer.json to cause VS Code its sub-processes (terminals, tasks, | ||
# debugging) to execute as the user. Uncomment the next line if you want the entire | ||
# container to run as this user instead. Note that, on Linux, you may need to | ||
# ensure the UID and GID of the container user you create matches your local user. | ||
# See https://aka.ms/vscode-remote/containers/non-root for details. | ||
user: vscode | ||
|
||
volumes: | ||
# Update this to wherever you want VS Code to mount the folder of your project | ||
- ..:/workspace:cached | ||
|
||
# Uncomment the next line to use Docker from inside the container. See https://aka.ms/vscode-remote/samples/docker-from-docker-compose for details. | ||
# - /var/run/docker.sock:/var/run/docker.sock | ||
|
||
# Overrides default command so things don't shut down after the process ends. | ||
#command: /bin/sh -c "while sleep 1000; do :; done" | ||
command: sleep infinity | ||
expose: | ||
- "6012" | ||
networks: | ||
- notify-network | ||
|
||
networks: | ||
notify-network: | ||
external: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will attach to the custom network defined in the API project, where it is created. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,5 +10,5 @@ set -ex | |
# Tell git the workspace repository is safe, else upcoming commands will fail. | ||
git config --global --add safe.directory /workspaces/notification-admin | ||
|
||
chown -R vscode:vscode /workspaces/notification-admin | ||
sudo -u vscode -i -- /usr/local/bin/installations.sh | ||
# Install and setup dev environment | ||
installations.sh | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was wondering how this script was called previously but could not find it. Does that look ok if I call it from here? cc @jzbahrai @whabanks @andrewleith |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a docker-compose.yml file gives us more options to customize our VSCode devcontainers.