Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nav pill styles #1971

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Update nav pill styles #1971

merged 5 commits into from
Oct 18, 2024

Conversation

andrewleith
Copy link
Member

@andrewleith andrewleith commented Oct 17, 2024

Summary | Résumé

This PR updates the nav pill styles with the new design as part of the annual limits work.

Before

image

After

image

Test instructions | Instructions pour tester la modification

This component is used in the following screens:

  • Job details delivery report (click on a job from the dashboard)
  • Notifications report page (click on the number of notifications sent from the dashboard)
  • Templates used page (click on "See all templates used" on the dashboard)
  • Messages sent page (click on "See all messages sent" on the dashboard)

Copy link

Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functionality still intact on screen readers too.

Copy link
Contributor

@amazingphilippe amazingphilippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested one tiny change!

app/assets/stylesheets/tailwind/components/pill.css Outdated Show resolved Hide resolved
@andrewleith andrewleith merged commit 220577b into main Oct 18, 2024
10 checks passed
@andrewleith andrewleith deleted the task/update-pill-styles branch October 18, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants